Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🆙 Set minimum Python version for plum to Python 3.8 #94

Merged
merged 1 commit into from
Aug 17, 2023
Merged

🆙 Set minimum Python version for plum to Python 3.8 #94

merged 1 commit into from
Aug 17, 2023

Conversation

gabrieldemarmiesse
Copy link
Contributor

Python 3.7 end of support for security bugs was the 5th of june 2023.

Some notes here:

  • This allows the python version in pre-commit to be the same as the one installed for testing of plum (3.8) because before, the pre-commit python version was 3.8 and the minimum python version for plum was 3.7.
  • Since typing.Literal is available in python 3.8, I think plum.Val can be now deprecated. I made the related changes.
  • get_args and get_origin can now be imported normally.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5878268210

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5864280507: 0.0%
Covered Lines: 922
Relevant Lines: 922
💛 - Coveralls

@wesselb
Copy link
Member

wesselb commented Aug 17, 2023

This is great! Removes a whole bunch of annoying boilerplate. Thanks!! :)

@wesselb wesselb merged commit 5ded84f into beartype:master Aug 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrieldemarmiesse @coveralls @wesselb